Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a line number mismatch issue between returned content and source code by adjusting 0-based to 1-based line numbering in source map parsing functionality.
- Adjusts line numbering to use 1-based indexing instead of 0-based for consistency with user expectations
- Updates both token generation and context lookup functions to return human-readable line numbers
- Maintains internal 0-based calculations while converting output to 1-based numbering
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/source_map_parser/src/token_generator.rs | Updates line number calculation in token generation and context lookup to use 1-based indexing |
| crates/source_map_parser/src/context_lookup.rs | Adjusts context snippet line numbering to return 1-based line numbers |
Comments suppressed due to low confidence (2)
crates/source_map_parser/src/token_generator.rs:237
- This test assertion expects line 0, but after the fix, the line numbering should be 1-based. This test should be updated to assert
tok.line == 1to reflect the corrected line numbering behavior.
assert_eq!(tok.line, 0); // original line
crates/source_map_parser/src/context_lookup.rs:50
- The context lines are still using 0-based line numbers (
ln) while the main line number was converted to 1-based. For consistency, the context line numbers should also be 1-based:line: ln + 1.
context.push(ContextLine {
line: ln,
is_target: ln == origin_line,
code,
});
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.